-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ZSA-related state enhancements and new getassetstate RPC call #33
base: zsa-integration-demo
Are you sure you want to change the base?
Conversation
…n-finalized chain.
…callyVerifiedBlock types, updates `IssuedAssetsChange::from_transactions()` method return type
…heckpointVerifiedBlock
…f BE for amount, read amount after asset base)
…state, add a couple of FIXMEs
…ror in the function of the crate (this may not be a fully correct fix). Add a couple of FIXME comments explaining the problem.
…64 to prevent serialization errors and enable defining BurnItem in orchard, facilitating its reuse along with related functions
…instead of try_from')
…instead of try_from') (2)
…tead of amount (with_asset is used to process orchard burn) - this allows avoiding the use of try_into for burn in binding_verification_key function
…s) to Orchard ZSA
…plate-rpcs feature enabled
.github/workflows/ci-basic.yml
Outdated
-A clippy::needless_lifetimes \ | ||
-A missing-docs \ | ||
-A non_local_definitions \ | ||
-A clippy::needless_return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to ignore single lines (and fix later) than disable entirely
https://stackoverflow.com/a/55402970
// TODO: Update `Burn` to `HashMap<AssetBase, NoteValue>)` and return an error during deserialization if | ||
// any asset base is burned twice in the same transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this could make it harder to consistently serialize in the same order, I'll add the check here.
…rs came with Rust 1.83.0
@arya2 I have a couple of questions about the asset state management code.
|
Yep, thank you for catching that.
|
This update incorporates the latest state enhancements for ZSA, including tracking the asset total supply and finalization flag. Additionally, the
getassetstate
RPC call has been implemented to allow querying the state of specific assets. See PRs #26, #32, and #29 for more details.getassetstate
call be tested using the followingcurl
command after starting the node:Ensure to replace the params with the correct hex-encoded asset ID (asset base) and specify the correct port and address.
You can also specify an optional boolean flag in
params
to include assets from the non-finalized state in the response. The flag defaults totrue
if omitted. For example: