feat(client): Display player's first character ped... #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulled into my latest qbox unstable dev server and it's working as intended, looks great |
mafewtm
reviewed
Oct 17, 2024
mafewtm
reviewed
Oct 17, 2024
|
I think it might be best if we just don't display any character if none exist. Although that could be out of scope for this PR. |
solareon
reviewed
Oct 31, 2024
|
Sooooo, whats up? |
|
Waiting on you to act on the remaining code suggestions. |
…if theres a character
|
@SSnowly fixed the changes for you. can you test and report back please |
Manason
previously approved these changes
Dec 1, 2024
D4isDAVID
requested changes
Dec 1, 2024
…ctions and take characters table.
D4isDAVID
approved these changes
Dec 17, 2024
mafewtm
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display's the player's first character -if it exists- instead of a random ped. If there is no characters, it displays a random Ped as the default does.
The video: in discord
Checklist