Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): add duffel bag check #645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

5hahfivem
Copy link

Description

This pull request adds a feature to check if a player is wearing a duffel bag.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use cases for this? It seems pretty specific to be in lib. Are we going to end up with 100s of functions to check if they are wearing x model?

@5hahfivem
Copy link
Author

Currently have it running on my bank robbery, back items. Anything that would realistically require a duffel bag, I did it for myself, but I PR'ed it since the iswearinggloves ft is handy, with the use cases for a duffel bag requirement I thought it to be equally as useful for others.

@FjamZoo
Copy link
Contributor

FjamZoo commented Jan 3, 2025

I don't think this belongs in a "core", it just ends up having a lot of bloated functions.

Even the "glove" checks dosn't belong in the core and should be moved to somewhere like Evidence.

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit on the fence about whether this makes sense, but it is in the same category as gloves, so unless we can think of a better place, it could be useful to many scripts to have this and therefore it makes sense to be in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants