Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: weapons that damage player synced more efficiently with server #46

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Nov 20, 2023

  • changed to a set (table<hash, boolean>) for more efficient lookups
  • renamed variable to be more descriptive
  • removing client side exports for reviving as this should originate from the server
  • syncing less data to the server (only when a new weapon damages a player it sends that one only instead of all previous weapons)
  • removed unneeded callbacks. i.e. the server asks the client to revive themselves, and clears the set rather than have the client callback to the server to do it

@Manason Manason merged commit 29d91ad into main Nov 20, 2023
2 checks passed
@Manason Manason deleted the refactor-weapons-that-damaged-players branch November 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant