Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using death state as a statebag #50

Merged
merged 2 commits into from
Nov 22, 2023
Merged

refactor: using death state as a statebag #50

merged 2 commits into from
Nov 22, 2023

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Nov 22, 2023

  • updating player's metadata for isDead and inLaststand when death state changes

@Manason Manason requested a review from FjamZoo November 22, 2023 16:08
FjamZoo
FjamZoo requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@FjamZoo FjamZoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's 1 change requested and 1 question :)

server/main.lua Outdated Show resolved Hide resolved
server/main.lua Outdated Show resolved Hide resolved
@Manason Manason requested a review from FjamZoo November 22, 2023 16:58
@Manason Manason merged commit f78e39d into main Nov 22, 2023
2 of 3 checks passed
@Manason Manason deleted the deathstate-statebag branch November 22, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FjamZoo FjamZoo FjamZoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manason @FjamZoo