Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta files, bl scenarios, and added lib #63

Merged
merged 3 commits into from Feb 7, 2024
Merged

Remove meta files, bl scenarios, and added lib #63

merged 3 commits into from Feb 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2024

Description

Gets rid of old base game meta files, blacklisted scenarios, and adds lib

Checklist

  • [ x ] I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • [ x ] My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@mafewtm mafewtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the code and empty config table for the BlacklistedScenarios['TYPES'} so that it can be utilized but there's no need for us to define all those scenarios to blacklist.

@ghost
Copy link
Author

ghost commented Jan 25, 2024

I'd keep the code and empty config table for the BlacklistedScenarios['TYPES'} so that it can be utilized but there's no need for us to define all those scenarios to blacklist.

Ok I'll add the empty config back

@bicatcho11
Copy link
Contributor

You can only comment on it
In order to make it easier for users to activate or reactivate them instead of using Google to search for each one and what its function is
OR using true false to active

@bicatcho11
Copy link
Contributor

I think deleting these files requires more thought
'popgroups.ymt',
'relationships.dat'

client/ignore.lua Outdated Show resolved Hide resolved
@mafewtm
Copy link
Member

mafewtm commented Jan 25, 2024

I think deleting these files requires more thought 'popgroups.ymt', 'relationships.dat'

Why would this require more thought?

Copy link
Contributor

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@solareon solareon merged commit 2e5b9de into Qbox-project:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants