Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(consumables): callback #67

Merged
merged 3 commits into from
Feb 12, 2024
Merged

refactor(consumables): callback #67

merged 3 commits into from
Feb 12, 2024

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Feb 8, 2024

Description

  • Fix improper parameters on some of the natives
  • Use ox_lib progressbar anims and props over scully emotes
  • Use a callback for item usages instead of individual events

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

TonybynMp4
TonybynMp4 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@TonybynMp4 TonybynMp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goot change

BerkieBb
BerkieBb reviewed Feb 11, 2024
View reviewed changes
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
client/consumables.lua Outdated Show resolved Hide resolved
@mafewtm mafewtm requested a review from BerkieBb February 12, 2024 00:19
@mafewtm mafewtm merged commit d8994b6 into Qbox-project:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonybynMp4 TonybynMp4 TonybynMp4 approved these changes

@BerkieBb BerkieBb BerkieBb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafewtm @BerkieBb @TonybynMp4