Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: buildWhereClause with table.concat #12

Merged
merged 2 commits into from
Jun 18, 2024
Merged

refactor: buildWhereClause with table.concat #12

merged 2 commits into from
Jun 18, 2024

Conversation

artur-michalak
Copy link
Contributor

Description

Suggestion of buildWhereClause implementation.
Decide which version is easier to read.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Manason
Manason suggested changes Jun 17, 2024
View reviewed changes
server/main.lua Show resolved Hide resolved
Manason
Manason approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@Manason Manason merged commit a229d49 into main Jun 18, 2024
4 checks passed
@Manason Manason deleted the query branch June 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artur-michalak @Manason