feat: assertions for required parameters #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solareon
approved these changes
Jun 22, 2024
artur-michalak
approved these changes
Jun 22, 2024
why many code when few code do trick |
We want to fail loudly when spec isn't being followed. Errors as values fail silently, and are for errors that the client needs to handle. In this case, the fault is with the client, so the client wouldn't handle this error, rather they would fix themselves. Even though lua is interpreted, a good rule of thumb is assertions are for issues that could be caught at "compile" time, whereas errors as values are for runtime issues caused by the state of the system or user input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes error handling of incorrect specification to assertions instead of errors as values.