-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing and debugging guide page to docs #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy! This looks like it covers a good amount of ground for testing/debugging.
The one thing that comes to mind as nice to add is a note on hitting static_assert
inside CPython, and what that could mean. @ngoldbaum it looks like you're going to review this PR in more detail? If so, maybe you could add this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some text suggestions and comments.
@rgommers agreed we need a section covering common error messages for google to index. If you don't mind I'll go ahead and add a FAQ section in a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy! Ralf and Nathan covered most of it, but I left a couple of comments as well.
SGTM! |
Co-authored-by: Nathan Goldbaum <[email protected]> Co-authored-by: Lysandros Nikolaou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the updated text looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks @andfoy! And thanks @ngoldbaum and @lysnikolaou for the reviews.
This adds a documentation page that highlights some of the steps for how to go about testing free-threading Python for a library.