update porting guide #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
reviewed
Oct 17, 2024
docs/porting.md
Outdated
| thread-safe, please do not open issues asking to fix thread safety issues in | ||
| PyTest itself. | ||
|
|
||
| #### The `warnings` module is not thread safe |
There was a problem hiding this comment.
We should probably be consistent in using either thread safe or thread-safe. No preference on my side.
There was a problem hiding this comment.
Ended up going with "thread-safe" and "thread safety", which follows wikipedia's style.
ngoldbaum
force-pushed
the
update-porting-guide
branch
from
cb1f819 to
ae17365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
Ping @ogrisel.
I added discussion about working with thread-unsafe tests and expanded the discussion about
PyMutexand the critical section API to discuss the interaction with the GIL.Also re-organized a little bit and changed the ToC hierarchy to make it flow better IMO.