tx-signing-service PR #2 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
get_indexer_config_idandget_function_call_requestI am not sure how to serialize the data coming from the
JsonRpcClientas aRpcQueryResponsebecause I couldn't find a good example so right now I am doing ajson-to-stringof theRpcQueryResponseobject assuming it will have aindexer_config_idfield, then I am extracting that value and returning it.Since I don't have a way to test the rpc call right now I can use any suggestions, in the meantime I will keep doing research when I have another free spot during the day