Improve introduction category #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix0rai
reviewed
Dec 29, 2023
wiki/introduction/setting-up.md
Outdated
| @@ -111,7 +111,7 @@ You'll need to update a few things under `"quilt_loader"`, see below for a final | |||
| but typically people put a `"homepage"`, a `"sources"`, and a `"issues"` entry with a valid URL here. | |||
| 5. Replace `example_mod` with your mod's ID in `"icon"`. | |||
| 4. In `"entrypoints"`, replace `com.example.example_mod` with your Maven group and mod ID, | |||
| and the `ExampleMod` at the end should be the Java class name for your mod. The Java class name usually is your mod's name, written in `UpperCamelCase` (So new words simply start by using a uppercase letter and the initial latter is also upper case) | |||
| and the `ExampleMod` at the end should be the Java class name for your mod. The Java class name usually is your mod's name, written in `UpperCamelCase` (So new words simply start by using an uppercase letter and the initial latter is also upper case) | |||
There was a problem hiding this comment.
uppercase latter is another typo, this sentence is also semantically pretty bad and should just get a rewrite
anonymous123-code
force-pushed
the
more-introduction-improvements
branch
from
3089b32 to
e1f210c
Compare
ix0rai
reviewed
Dec 29, 2023
wiki/introduction/get-started/en.md
Outdated
|
|
||
| Many problems have been solved in modding before, and are publicly available for you | ||
| to see and use as most mods for Quilt are open source. We recommend that you look at | ||
| examples of how to do things in open source repositories and sometimes "steal" code. | ||
| Open source repositories are there for you to learn from and use, don't be afraid of | ||
| them! | ||
|
|
||
| TODO: Levi write your thing about stealing code here | ||
| There are many topics in modding where you quickly will find yourself at a point where tutorials are missing. In those cases you'll usually either have to understand the relevant Minecraft code, or look at other mods and see how they got similar things done. |
There was a problem hiding this comment.
Suggested change
| There are many topics in modding where you quickly will find yourself at a point where tutorials are missing. In those cases you'll usually either have to understand the relevant Minecraft code, or look at other mods and see how they got similar things done. | |
| There are many topics in modding where you quickly will find yourself at a point where there are no tutorials to help. In those cases you'll usually either have to understand the relevant Minecraft code, or look at other mods and see how they got similar things done. |
I think a quick explainer on how to see game code (vineflower gen sources) would fit nicely here
ix0rai
approved these changes
Dec 29, 2023
ix0rai
added
content
OroArmor
approved these changes
Jan 4, 2024
|
@anonymous123-code resolve conflicts and we can merge this! |
- Fix typos, - Better wording - Add explanation for genSources Co-authored-by: ix0rai <[email protected]>
anonymous123-code
force-pushed
the
more-introduction-improvements
branch
from
03c8bc4 to
d8955fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes several TODOs:
This does not sync the french translation.
See preview on Cloudflare Pages: https://preview-74.developer-wiki.pages.dev