-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding custom world presets #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should explain what a custom world preset is and why you would want to make one!
a reason for making a whole new world preset/type is if you're making a mod that changes MC's worldgen across the board, you can give people the option to use your worldgen or MC's vanilla worldgen |
word that nicely and pop it in the article! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would look at https://minecraft.wiki/w/Custom_world_preset for more information on what this feature is and also link it to this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still confusing and doesnt follow the object hierarchy well. Base the explanation more off of the wiki article
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs a lot of work.
```json | ||
"dimensions": { | ||
"minecraft:overworld": { | ||
"type": "minecraft:overworld" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type here isnt explained. Its the actual world type. In addition, the name of the object is the dimension name, and besides requiring minecraft:overworld
, nothing else is. Make this distinction clearer.
debug | ||
``` | ||
|
||
`biome_source` is where you specify how biomes generate. The `type` parameter here is what kind of biome generation will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me think that i can add this to a flat or debug world, which is wrong. Make sure you a clear distinction of what fields are supported by what generator types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please set up the article to display in the actual web page
- you kinda toss in the code blocks without introducing them. in my articles, I like to always at least state the goal of the code we're adding before showing it
- every code block should have the full path to its file before it
</br> | ||
|
||
Here is where you specify which dimensions your world preset will apply to. It does require a `minecraft:overworld` dimension or your world preset will not work. | ||
Valid dimensions are `minecraft:overworld`, `minecraft:nether` and `minecraft:the_end`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as well as dimensions added by mods, I assume?
</br> | ||
</br> | ||
|
||
Here is where you specify which dimensions your world preset will apply to. It does require a `minecraft:overworld` dimension or your world preset will not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes it sound like it specifically requires the overworld
dimension, is that right?
noise | ||
flat | ||
debug | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain these!
Co-authored-by: ix0rai <[email protected]>
Co-authored-by: ix0rai <[email protected]>
this should be done automatically without any work from a PR creator |
Maybe, but for now its not. |
two reasons we can't do that:
|
See preview on Cloudflare Pages: https://preview-79.developer-wiki.pages.dev