Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom world presets #79

Closed
wants to merge 32 commits into from
Closed

adding custom world presets #79

wants to merge 32 commits into from

Conversation

woodiertexas
Copy link
Contributor

@woodiertexas woodiertexas commented Jan 29, 2024


See preview on Cloudflare Pages: https://preview-79.developer-wiki.pages.dev

@ix0rai ix0rai changed the title this is from several months ago lol adding custom world presets Jan 29, 2024
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should explain what a custom world preset is and why you would want to make one!

@ix0rai ix0rai changed the title adding custom world presets adding custom world presets & fmj vs qmj Jan 29, 2024
wiki/misc/qmjfmj.md Outdated Show resolved Hide resolved
@woodiertexas
Copy link
Contributor Author

this should explain what a custom world preset is and why you would want to make one!

a reason for making a whole new world preset/type is if you're making a mod that changes MC's worldgen across the board, you can give people the option to use your worldgen or MC's vanilla worldgen

@ix0rai ix0rai changed the title adding custom world presets & fmj vs qmj adding custom world presets Jan 29, 2024
@ix0rai ix0rai added content Relates to the content of the wiki new page adds a new wiki page labels Jan 29, 2024
@ix0rai
Copy link
Member

ix0rai commented Jan 29, 2024

this should explain what a custom world preset is and why you would want to make one!

a reason for making a whole new world preset/type is if you're making a mod that changes MC's worldgen across the board, you can give people the option to use your worldgen or MC's vanilla worldgen

word that nicely and pop it in the article!

@woodiertexas woodiertexas requested a review from ix0rai January 29, 2024 02:35
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
@woodiertexas woodiertexas requested a review from ix0rai January 29, 2024 03:18
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would look at https://minecraft.wiki/w/Custom_world_preset for more information on what this feature is and also link it to this page

wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
@woodiertexas woodiertexas requested a review from OroArmor January 30, 2024 05:23
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still confusing and doesnt follow the object hierarchy well. Base the explanation more off of the wiki article

wiki/misc/worldtypes.md Show resolved Hide resolved
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a lot of work.

wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
```json
"dimensions": {
"minecraft:overworld": {
"type": "minecraft:overworld"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type here isnt explained. Its the actual world type. In addition, the name of the object is the dimension name, and besides requiring minecraft:overworld, nothing else is. Make this distinction clearer.

debug
```

`biome_source` is where you specify how biomes generate. The `type` parameter here is what kind of biome generation will be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think that i can add this to a flat or debug world, which is wrong. Make sure you a clear distinction of what fields are supported by what generator types.

wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please set up the article to display in the actual web page
  • you kinda toss in the code blocks without introducing them. in my articles, I like to always at least state the goal of the code we're adding before showing it
  • every code block should have the full path to its file before it

wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
</br>

Here is where you specify which dimensions your world preset will apply to. It does require a `minecraft:overworld` dimension or your world preset will not work.
Valid dimensions are `minecraft:overworld`, `minecraft:nether` and `minecraft:the_end`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as dimensions added by mods, I assume?

</br>
</br>

Here is where you specify which dimensions your world preset will apply to. It does require a `minecraft:overworld` dimension or your world preset will not work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it sound like it specifically requires the overworld dimension, is that right?

noise
flat
debug
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain these!

wiki/misc/worldtypes.md Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
@woodiertexas
Copy link
Contributor Author

  • please set up the article to display in the actual web page

this should be done automatically without any work from a PR creator

@OroArmor
Copy link
Member

OroArmor commented Feb 7, 2024

  • please set up the article to display in the actual web page

this should be done automatically without any work from a PR creator

Maybe, but for now its not.

wiki/misc/worldtypes.md Outdated Show resolved Hide resolved
@ix0rai
Copy link
Member

ix0rai commented Feb 7, 2024

  • please set up the article to display in the actual web page

this should be done automatically without any work from a PR creator

two reasons we can't do that:

  • metadata: the creator needs to decide which category and what order their page should display on
  • translation: we need the page to be i18n-able

@woodiertexas woodiertexas closed this by deleting the head repository Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relates to the content of the wiki new page adds a new wiki page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants