Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message to be less "scary" #176

Closed
wants to merge 6 commits into from
Closed

Fix warning message to be less "scary" #176

wants to merge 6 commits into from

Conversation

woodiertexas
Copy link
Contributor

@woodiertexas woodiertexas commented Dec 11, 2023

All I did was make it use the success styling found in the "Powerful" message box on the main site. I also was unable to test this locally because of this: https://mclo.gs/wr6vtB4


See preview on Cloudflare Pages: https://preview-176.quiltmc-org.pages.dev

@ix0rai
Copy link
Member

ix0rai commented Dec 11, 2023

not a fan. making it green is misleading, and the motion graphic is super annoying. I'd personally like to make the box yellow with #173

@woodiertexas
Copy link
Contributor Author

Going to figure out how to remove that "graphic" btw

@woodiertexas
Copy link
Contributor Author

This was rather annoying to fix ngl:
image

Copy link
Member

@Pyrofab Pyrofab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea, the warning style looks good for this

@ix0rai
Copy link
Member

ix0rai commented May 5, 2024

image-34.png

imo this looks quite a bit worse on light mode

@UpcraftLP
Copy link
Contributor

Seems like this would need to be changed in https://github.com/QuiltMC/quilt-bulma/blob/6a55ad3f40587198959b4c4e28468f6002954344/sass/common/colours.scss#L8 instead.

I think merging this to change the message style from danger to warning is fine however.

@woodiertexas woodiertexas closed this by deleting the head repository May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants