-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gdlauncher install page and reorganise install page #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issues with this pr:
I don't really have the webdev knowhow to fix either |
GDLauncher added quilt support in The Crabon Rewrite |
hm. if I'm calling the shots here, we'll restore the gdlauncher install page when their carbon version becomes generally available |
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i learned bulma for this
gdlauncher development, as well as its PR for quilt support, has been stagnant for nearly a year (the quilt PR after receiving absolutely no comment from the gdlauncher developers for a full year), so it doesn't seem like it'll ever be added. with no elements on the "awaiting support" page, we can remove it altogether.GDlauncher has released a big update adding support for quiltold on right, new on left

only real issue with this PR is the wip box being a different size than the buttons which is super annoying but can be fixed later
See preview on Cloudflare Pages: https://preview-185.quiltmc-org.pages.dev