Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gdlauncher install page and reorganise install page #185

Merged
merged 7 commits into from
Mar 31, 2024

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Mar 7, 2024

i learned bulma for this

gdlauncher development, as well as its PR for quilt support, has been stagnant for nearly a year (the quilt PR after receiving absolutely no comment from the gdlauncher developers for a full year), so it doesn't seem like it'll ever be added. with no elements on the "awaiting support" page, we can remove it altogether. GDlauncher has released a big update adding support for quilt

old on right, new on left
image

only real issue with this PR is the wip box being a different size than the buttons which is super annoying but can be fixed later


See preview on Cloudflare Pages: https://preview-185.quiltmc-org.pages.dev

@ix0rai
Copy link
Member Author

ix0rai commented Mar 7, 2024

issues with this pr:

  • mismatched box sizes
  • there should be a limit on buttons per row (I'm thinking 4)

I don't really have the webdev knowhow to fix either

@woodiertexas
Copy link
Contributor

i personally think this box should be yellow too:
image

@KennyDevT
Copy link

GDLauncher added quilt support in The Crabon Rewrite

@ix0rai
Copy link
Member Author

ix0rai commented Mar 9, 2024

hm. if I'm calling the shots here, we'll restore the gdlauncher install page when their carbon version becomes generally available

@KennyDevT
Copy link

ok

@ix0rai ix0rai added the enhancement New feature or request label Mar 9, 2024
@KennyDevT
Copy link

Screenshot from 2024-03-22 22-13-50 GDLauncher Carbon has been released with quilt support

@ix0rai ix0rai changed the title remove gdlauncher and reorganise install page update gdlauncher install page and reorganise install page Mar 25, 2024
@ix0rai ix0rai enabled auto-merge (squash) March 31, 2024 00:53
@ix0rai ix0rai disabled auto-merge March 31, 2024 00:59
@ix0rai ix0rai merged commit 20ca313 into QuiltMC:main Mar 31, 2024
1 check passed
@ix0rai ix0rai deleted the remove-gd branch March 31, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants