Expand logging capabilities

[nikijaz]

This PR expands logging capabilities and fixes some bugs. This also includes changes from #119 by Altirix.

Added logging of:

• Dyeing and shearing sheep (Including evoker as a source)
• Breaking a bed due to interaction (Fixes Bed Destroy (Nether or End) marked as @gravity #168)
• Breaking a cactus, sugarcane, and chorus because of gravity
• Shooting a chorus flower
• Destroying a wither or (snow) golem statue
• Modifying a state of comparator or repeater
• Opening or closing a door, trapdoor, fence gate (Including redstone as a source)
• Breaking a lily pad with a boat
• Changing or destroying an armor stand (Fixes Armor stand interactions are not logged #129)
• Changing or destroying a frame (Fixes Track item frames and the item inside of them #216)
• Painting a dog or cat collar
• Breaking blocks by an ender dragon (Fixes Ledger doesn't log blocks destroyed by Ender Dragon #182)
• Dropping and picking up items (Fixes Log more actions, add more commands #156)
• Setting fire with lightning (Fixes Log fire placed by lightning bolt #147)
• Making snow with a snow golem
• Turning a villager into a witch because of lightning
• Inserting or removing a book from a lectern

[DrexHD]

Wow! This is a pretty big PR with a lot of changes.
I have added some small reviews to some parts of the code. I am putting some other things I would like to mention that didn't fit a specific piece of code here:

• @ModifyArgs is used in a couple of Mixins to get easy access to arguments. According to the Java Doc of ModifyArgs, it is pretty inefficient and this isn't really its intended use-case. I suggest using LocalCapture instead.
• This PR added a couple of mixins for plants breaking. Their source is Gravity, I think it would be great to add a separate source type for this, to allow better user blacklists (This would apply to CactusBlockMixin, SugarCaneBlockMixin, BambooBlockMixin, ChorusPlantBlock, and PointedDripstoneBlockMixin)
• This is probably a design choice, but since entity modify actions store entity positions, the entity is moved back to the action pos when rolling back (even if the position doesn't really matter, like dyeing).
• Item frame logging didn't work properly when I tried rolling back @equip actions
• When placing carved pumpkins (and probably wither skeleton skull) it first logs the block being broken by snowman spawning and then tries to log the placed block, but since it's no longer there it logs placing air (so the order is incorrect and the placed block is wrong)
• ItemDropActionType and ItemPickUpActionType should implement rollback / restore

Thanks for the PR!

[suerion]

I think on this Pull Request, there should also be the #202 projectile shoot event

[nikijaz]

@ModifyArgs is used in a couple of Mixins to get easy access to arguments. According to the Java Doc of ModifyArgs, it is pretty inefficient and this isn't really its intended use-case. I suggest using LocalCapture instead.

Fixed!

This PR added a couple of mixins for plants breaking. Their source is Gravity, I think it would be great to add a separate source type for this, to allow better user blacklists (This would apply to CactusBlockMixin, SugarCaneBlockMixin, BambooBlockMixin, ChorusPlantBlock, and PointedDripstoneBlockMixin)

I honestly don't see much point in it. After all, the remaining parts of the plants are destroyed just by gravity, which is exactly what fits this source.

This is probably a design choice, but since entity modify actions store entity positions, the entity is moved back to the action pos when rolling back (even if the position doesn't really matter, like dyeing).

Fixed, now only custom entity data is rolled back.

Item frame logging didn't work properly when I tried rolling back @equip actions

When using readNbt() for an ItemFrame entity with an existing item stack in it, if the new NBT does not have an item stack, it will not be removed from the entity. I made a simple workaround for this that should work.

When placing carved pumpkins (and probably wither skeleton skull) it first logs the block being broken by snowman spawning and then tries to log the placed block, but since it's no longer there it logs placing air (so the order is incorrect and the placed block is wrong)

I don't know how to fix it. onPlaced() is processed before the final installation of the block, so I have no idea.

ItemDropActionType and ItemPickUpActionType should implement rollback / restore

Implemented, but without returning items to the player's inventory, as I consider it unnecessary.

[DrexHD]

The new changes look pretty good 👍. I have left some more change request on some minor issues.

I have also noticed an issue, when rolling back an armorstand that was first equipped and then killed. (The killing gets rolled back, but equipping doesn't, if both are rolled back in one operation)! I don't know what might cause this atm.
I think you should also remove the code duplication in ItemDropActionType and ItemPickUpActionType rollback/restore.

Sorry for the slow responses, I was/am kind of busy currently

[AphoticGoblin]

This isn't compatible with Goodall. There's an item called the Animal Crate that can capture animals, that isnt logged by this.

[DrexHD]

Looks good to me!

[Dev0Louis]

Any news on this?

[Rozbiynk]

any updates?

[transcental]

Would it be possible for this to be merged soon? Had an issue on my server that this would've solved but instead I had to go and move region files from an old backup as ledger hadn't logged the destruction.

[Rozbiynk]

i hope it will have 1.20.1 version

[TheDeathlyCow]

I've done some testing and can confirm that this branch works on 1.20.2 by just merging in 1.2.9.

There are, however, a couple of issues when merging in update to 1.20.4.

First, The setBlockState target for the injection TrapdoorBlockMixin#logTrapdoorInteraction no longer exists. I think this can be fixed by changing the target to the flip call instead, as that seems to be the replacement.

Second, the BedBlockMixin has some invalid descriptors. It seems that onBreak now returns a BlockState so just changing the callback info param to CallbackInfoReturnable<BlockState> fixes that.

Those are the only 2 errors I encountered with 1.20.4. Fixing them locally gets the mod running, and everything still seems to work.

Hope this PR gets merged soon, it has some really nice features!

[PotatoPresident]

I can't help but feel that sources is being misused, but I don't really have a better alternative other than making a ton of different action types.