Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #248

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix build issues #248

merged 3 commits into from
Apr 23, 2024

Conversation

pompompopi
Copy link
Contributor

Implementation of the potential solution described in #247.

@pompompopi pompompopi requested a review from a team as a code owner April 20, 2024 22:34
@pompompopi pompompopi changed the title Fix build issues (fixes #247) Fix build issues Apr 20, 2024
Copy link
Member

@PotatoPresident PotatoPresident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump fabric loader version to latest to fix an issue with pulling in a mod with a newer loader version

@pompompopi
Copy link
Contributor Author

Bump fabric loader version to latest to fix an issue with pulling in a mod with a newer loader version

I've updated the Fabric loader version to the latest as requested, however I haven't updated the minimum version in the fabric.mod.json as it didn't match the actual loader version. Should that be bumped too, or should I leave it as is?

@PotatoPresident PotatoPresident merged commit 860ba1f into QuiltServerTools:master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants