Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): only inject css link tags that have js importers #7267

Merged
merged 14 commits into from
Jan 30, 2025
Merged

fix(dev): only inject css link tags that have js importers #7267

merged 14 commits into from
Jan 30, 2025
+38 −23

Conversation

thejackshelton
Copy link
Member

@thejackshelton thejackshelton commented Jan 18, 2025 •
edited
Loading

Builds on top of #7266, otherwise I can't build Qwik.

Fixes #5965 in the Qwik vite dev server.

@thejackshelton thejackshelton requested review from a team as code owners January 18, 2025 21:05
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4579fea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thejackshelton thejackshelton changed the title Css dev imports Dev Server should only inject link tags that have js importers Jan 18, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 18, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7267

npm i https://pkg.pr.new/@builder.io/qwik-city@7267

npm i https://pkg.pr.new/eslint-plugin-qwik@7267

npm i https://pkg.pr.new/create-qwik@7267

commit: 1267f9d

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1267f9d

Varixo
Varixo previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

packages/docs/src/routes/api/qwik/index.md Outdated Show resolved Hide resolved
@wmertens wmertens changed the title Dev Server should only inject link tags that have js importers fix(dev): only inject css link tags that have js importers Jan 22, 2025
@wmertens wmertens merged commit 684fe2b into main Jan 30, 2025
16 checks passed
@wmertens wmertens deleted the css-dev-imports branch January 30, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS left review comments

@Varixo Varixo Varixo approved these changes

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] Error with TailwindCSS 4 when used in Qwik
4 participants
@thejackshelton @wmertens @PatrickJS @Varixo