Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: move internals out of JSXNode" #7299

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Jan 31, 2025

This reverts commit 26af133.

What is it?

  • Bug

Description

qwik-ui can't be built since 1.11.0 since this commit. There seem to be some inconsistencies within the types. I tried fixing them but it looks like a good 1-2 days of work or more, and I'd like to focus on more urgent work.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested review from a team as code owners January 31, 2025 17:10
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 0fcac40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jan 31, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7299
npm i https://pkg.pr.new/@builder.io/qwik-city@7299
npm i https://pkg.pr.new/eslint-plugin-qwik@7299
npm i https://pkg.pr.new/create-qwik@7299

commit: 0fcac40

Copy link
Contributor

github-actions bot commented Jan 31, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 0fcac40

@maiieul maiieul closed this Jan 31, 2025
@maiieul
Copy link
Contributor Author

maiieul commented Jan 31, 2025

I found a fix. Just had to delete node_modules and pnpm-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant