Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve Auth.js integration page #7302

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

  • Docs

Description

Ciao Gio (it's usually Gio that reviews these)

As per discussion with Ian in Discord.

There are other references to redirectTo on this page.
But from my testing this morning the below is still valid,
So not every refence to redirectTo needed to be adjusted.

<Form action={signOut}>
      <input type="hidden" name="redirectTo" value="/signedout" />
      <button>Sign Out</button>
</Form>

Link to Discord Chat below:

https://discord.com/channels/842438759945601056/1334857616295333909

Checklist

@Shane-Donlon Shane-Donlon requested a review from a team as a code owner February 1, 2025 12:54
Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: be40de1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 1, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview be40de1

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shane-Donlon
It looks great to me, thanks 🎉👏
Auth.js internally is moving to redirectTo but in this case your fix it's awesome 😎

@gioboa gioboa added the COMP: docs Improvements or additions to documentation label Feb 1, 2025
@gioboa gioboa merged commit 993c578 into QwikDev:main Feb 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants