Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create svg nested children with correct namespace #7323

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Feb 7, 2025

In some cases vNodes didn't have the correct flags for the namespace

@Varixo Varixo self-assigned this Feb 7, 2025
@Varixo Varixo requested a review from a team as a code owner February 7, 2025 19:53
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: a7749a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo linked an issue Feb 7, 2025 that may be closed by this pull request
@Varixo Varixo marked this pull request as draft February 7, 2025 20:20
@Varixo Varixo force-pushed the v2-svg-nested-children-namespace branch from 681a359 to a7749a3 Compare February 7, 2025 20:31
Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7323
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7323
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7323
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7323

commit: a7749a3

@Varixo Varixo marked this pull request as ready for review February 7, 2025 20:44
Copy link
Contributor

github-actions bot commented Feb 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a7749a3

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 👍
Thanks @Varixo

@Varixo Varixo merged commit 2739ddc into build/v2 Feb 8, 2025
19 checks passed
@Varixo Varixo deleted the v2-svg-nested-children-namespace branch February 8, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] qwik-v2 playground ring disappears after clicking on "+"
2 participants