Optimise backfill #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yatharthranjan
commented
Oct 30, 2024
•
yatharthranjan
commented
- Handle the case when route is not enabled in garmin dev portal explicitly
- Remove backfill for blood pressures, hrv and health snapshot by default as these are new and not present in all devices.
- Make all the backfill streams configurable, so can be enabled/disabled at runtime
mpgxvii
approved these changes
Nov 14, 2024
|
|
||
| private val userNextRequest: MutableMap<String, Instant> = mutableMapOf() | ||
|
|
||
| private val routeNextRequest: MutableMap<Route, Instant> = mutableMapOf() |
There was a problem hiding this comment.
Should we just use the route string value here?
There was a problem hiding this comment.
yeah good point, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.