Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter on the front end for users #42

Closed
wants to merge 1 commit into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Jan 28, 2020

  • Adds filter on the front end to hide rest source user data from users who do not have the correct permissions from management portal (uses management portal assigned projects)
  • I guess this would be better implemented on the back end?

Partially solves #13

@yatharthranjan
Copy link
Member

hi @mpgxvii , I think yes this needs to be done from the backend based on the token provided by the frontend. The frontend should only be responsible for getting a valid token using auth code flow.

@mpgxvii
Copy link
Member Author

mpgxvii commented Mar 11, 2020

@yatharthranjan Also, I was wondering maybe it would be good to implement this similar to Management Portal front end? Where projects (where the user has access to) are shown upon login?

@mpgxvii mpgxvii closed this Mar 30, 2020
@mpgxvii mpgxvii deleted the feat/filter-users branch March 30, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants