[data-dashboard-backend] Update charts for data dashboard backend service #196
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
data-dashboard-backend
branch
3 times, most recently
from
92dd4be to
71ca874
Compare
| # -- image pull policy | ||
| pullPolicy: Always | ||
| # Overrides the image tag whose default is the chart appVersion. |
There was a problem hiding this comment.
The comments should start with a -- in order to be added into README.md
There was a problem hiding this comment.
I did not know. Fixed!
There was a problem hiding this comment.
It doesn't seem to be fixed
| port: http | ||
| httpHeaders: | ||
| - name: Accept | ||
| value: application/json | ||
| readinessProbe: | ||
| httpGet: | ||
| path: /api/health | ||
| path: {{ .Values.path }}/health |
There was a problem hiding this comment.
Not really related to this PR but some of our components are pointed to a sub domain and some other to prefixes in the main domain and it's not clear for me when we use which one. I think we should have an agreement on it. I'll make an issue for it.
There was a problem hiding this comment.
Well, the grizzly application has this as a configurable option. The sub-path can be modified in the helmfile. I think that for this reason the helm chart must allow configuration of this path, in order to allow for outside changes of subpath?
There was a problem hiding this comment.
Yes that is true. It's good to have this configurable.
|
Thanks @pvannierop, please also add an entry for this component in the |
This is only a backend service. I think the home page only links to frontend applications, right? If so, we do not need to add it. |
That's right, I didn't notice that this was a backend only app. |
pvannierop
force-pushed
the
data-dashboard-backend
branch
3 times, most recently
from
f079969 to
dbd77ea
Compare
pvannierop
force-pushed
the
data-dashboard-backend
branch
2 times, most recently
from
6bcd429 to
b27bf22
Compare
pvannierop
force-pushed
the
data-dashboard-backend
branch
from
8a1b44a to
87e358d
Compare
pvannierop
changed the title
Description of the change
Data dashboard backend is a new service that exposes data from the observations table in timescaledb database (provisioned by KSQLDB service) to frontend/mobile applications. This PR will improve the helm chart for this service.
Checklist
Chart.yamlaccording to semver.