Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mongodb version #241

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Updated mongodb version #241

merged 1 commit into from
Aug 7, 2024

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Aug 6, 2024

Some files were missing from the last release.

@keyvaann keyvaann requested a review from Bdegraaf1234 August 6, 2024 18:44
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we know why the files were missed the first time?

@keyvaann
Copy link
Collaborator Author

keyvaann commented Aug 7, 2024

LGTM, do we know why the files were missed the first time?

Probably didn't run git add when committing and only committed existing files.

@keyvaann
Copy link
Collaborator Author

keyvaann commented Aug 7, 2024

@Bdegraaf1234 Still can't merge it for some reason and tells me that Review required

@Bdegraaf1234 Bdegraaf1234 self-requested a review August 7, 2024 09:01
@Bdegraaf1234
Copy link
Collaborator

Sorry, should be good to go now!

@keyvaann keyvaann merged commit 026843f into main Aug 7, 2024
2 checks passed
@keyvaann keyvaann deleted the update-mongodb branch August 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants