Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest-source-auth] Update rest-source-authorizer to 4.4.3 #247

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

Bdegraaf1234
Copy link
Collaborator

Description of the change

Update the rest source authorizer images

Benefits

Bugfix

Possible drawbacks

Applicable issues

NA

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 requested a review from keyvaann August 8, 2024 13:58
Copy link

github-actions bot commented Aug 8, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit bf36107 into main Aug 8, 2024
5 checks passed
@keyvaann keyvaann deleted the version/rest-source-auth-4.4.3 branch August 8, 2024 16:07
@Bdegraaf1234
Copy link
Collaborator Author

This chart is giving me unintended diffs now:

I cannot set the auth url, and the baseUrl is changed

Comparing release=radar-rest-sources-backend, chart=radar/radar-rest-sources-backend
default, radar-rest-sources-backend, ConfigMap (v1) has changed:
...
    labels:
-     helm.sh/chart: radar-rest-sources-backend-1.1.3
+     helm.sh/chart: radar-rest-sources-backend-1.1.5
      app.kubernetes.io/name: radar-rest-sources-backend
      app.kubernetes.io/instance: radar-rest-sources-backend
-     app.kubernetes.io/version: "4.4.2"
+     app.kubernetes.io/version: "4.4.3"
      app.kubernetes.io/managed-by: Helm
...
        baseUri: http://0.0.0.0:8080/rest-sources/backend/
-       advertisedBaseUri: https://radar-dev.connectdigitalstudy.com/rest-sources/backend/
+       advertisedBaseUri: http://radar-dev.connectdigitalstudy.com/rest-sources/backend/
        enableCors: true
Comparing release=radar-rest-sources-authorizer, chart=radar/radar-rest-sources-authorizer
default, radar-rest-sources-authorizer, Deployment (apps) has changed:
...
    labels:
-     helm.sh/chart: radar-rest-sources-authorizer-1.1.4
+     helm.sh/chart: radar-rest-sources-authorizer-2.0.1
      app.kubernetes.io/name: radar-rest-sources-authorizer
      app.kubernetes.io/instance: radar-rest-sources-authorizer
-     app.kubernetes.io/version: "4.4.2"
+     app.kubernetes.io/version: "4.4.3"
      app.kubernetes.io/managed-by: Helm
...
            - name: BACKEND_BASE_URL
-             value: https://radar-dev.connectdigitalstudy.com/rest-sources/backend
+             value: http://radar-dev.connectdigitalstudy.com/rest-sources/backend/
            - name: VALIDATE
...
            - name: AUTH_CALLBACK_URL
-             value: https://radar-dev.connectdigitalstudy.com/rest-sources/authorizer/login
+             value: http://radar-dev.connectdigitalstudy.com/rest-sources/authorizer/login
            - name: AUTH_URI
-             value: https://radar-dev.connectdigitalstudy.com/managementportal/oauth2
+             value: http://radar-dev.connectdigitalstudy.com/managementportal/oauth
            ports:

@keyvaann
Copy link
Collaborator

Maybe it is because of this PR? #226
We had similar changes to the charts recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants