Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radar-mockserver] Add mockserver charts #301

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

pvannierop
Copy link
Collaborator

This PR will add mockserver with a mockserver-config that facilitates the creating of expectations.

@pvannierop pvannierop requested a review from keyvaann November 18, 2024 15:00
@pvannierop pvannierop self-assigned this Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@keyvaann
Copy link
Collaborator

The lint is failing.

dependencies:
- name: mockserver
version: 5.15.0
repository: https://www.mock-server.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we want to mirror this chart in our own repository but I don't know how much it's necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a dependency on a chart in the external dir?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah apparently we can:

# Chart.yaml
dependencies:
- name: nginx
  version: "1.2.3"
  repository: "file://../dependency_chart/nginx"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have done it like this in the past
https://github.com/RADAR-base/radar-helm-charts/blob/main/charts/velero-s3-deployment/Chart.yaml#L11

I'm not sure if the file:// approach will work but if it does, it's fine then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works

@pvannierop
Copy link
Collaborator Author

@keyvaann I have added the external chart! Can you please re-review?

@pvannierop pvannierop force-pushed the feature/mockserver branch 3 times, most recently from 0f22012 to a5d0ce5 Compare November 19, 2024 15:34
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop merged commit b6c807a into main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants