-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[radar-mockserver] Add mockserver charts #301
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
The lint is failing. |
charts/radar-mockserver/Chart.yaml
Outdated
dependencies: | ||
- name: mockserver | ||
version: 5.15.0 | ||
repository: https://www.mock-server.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we want to mirror this chart in our own repository but I don't know how much it's necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a dependency on a chart in the external dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah apparently we can:
# Chart.yaml
dependencies:
- name: nginx
version: "1.2.3"
repository: "file://../dependency_chart/nginx"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have done it like this in the past
https://github.com/RADAR-base/radar-helm-charts/blob/main/charts/velero-s3-deployment/Chart.yaml#L11
I'm not sure if the file://
approach will work but if it does, it's fine then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it works
62455f7
to
23aa69e
Compare
@keyvaann I have added the external chart! Can you please re-review? |
0f22012
to
a5d0ce5
Compare
0ebecd3
to
54572b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will add mockserver with a mockserver-config that facilitates the creating of expectations.