[data-dashboard-backend] Change path for api to /dashboard-data #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
pvannierop
force-pushed
the
feature/data-dashboard-path
branch
from
fa007ce to
07c4a6c
Compare
pvannierop
force-pushed
the
feature/data-dashboard-path
branch
from
07c4a6c to
1659616
Compare
keyvaann
reviewed
Dec 18, 2024
| @@ -44,7 +43,7 @@ API for data in the data dashboard | |||
| | ingress.enabled | bool | `true` | Enable ingress controller resource | | |||
| | ingress.ingressClassName | string | `"nginx"` | Ingress class name | | |||
| | ingress.annotations | object | check values.yaml | Annotations that define default ingress class, certificate issuer | | |||
| | ingress.path | string | `"/api"` | Path within the url structure | | |||
| | ingress.path | string | `"/dashboard-data"` | Path within the url structure | | |||
There was a problem hiding this comment.
Is there a need for documentation to be updated for this? Or maybe the radar-home chart?
There was a problem hiding this comment.
@keyvaann No I do not think so. Since this is only a backend (used by aRMT for now) we not need it in radar-home. The change in this PR is there so we no longer have to set this in helmfile (done for MySkin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title