Impl. override of required config parameters #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
force-pushed
the
feature/allow-env-override-required-config-options
branch
from
52aca54 to
0a4ea47
Compare
pvannierop
force-pushed
the
feature/allow-env-override-required-config-options
branch
from
0a4ea47 to
a0df720
Compare
pvannierop
force-pushed
the
feature/allow-env-override-required-config-options
branch
from
a0df720 to
bbe5c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing copyEnv function does not allow to override config options that are not nullable (required parameters)
Solution
This PR will refactor the copyEnv function to allow setting both nullable and non-nullable config options.
Note
Tests were added to assert override of config by env vars.