Stop monitoring attribute changes when tool closed [#16185]

RBVI · Oct 28, 2024 · c28e2bf · c28e2bf
1 parent b1f63f9
commit c28e2bf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/bundles/render_by_attr/bundle_info.xml b/src/bundles/render_by_attr/bundle_info.xml
@@ -1,4 +1,4 @@
-<BundleInfo name="ChimeraX-RenderByAttr" version="1.6"
+<BundleInfo name="ChimeraX-RenderByAttr" version="1.6.1"
 	    package="chimerax.render_by_attr"
   	    minSessionVersion="1" maxSessionVersion="1">
 

diff --git a/src/bundles/render_by_attr/src/tool.py b/src/bundles/render_by_attr/src/tool.py
@@ -380,6 +380,15 @@ def default_render_worm_markers(self):
     def default_render_worm_markers(self, markers):
         self._default_render_worm_markers = self._clone_markers(markers)
 
+    def delete(self):
+        for index in [0,1]:
+            for attr_info, attr_monitorings in list(self._attr_monitorings.items()):
+                for attr_name, mode_monitoring in list(attr_monitorings.items()):
+                    if mode_monitoring[index]:
+                        attr_info.attr_change_notify(attr_name, None)
+        self._attr_monitorings.clear()
+        super().delete()
+
     def fill_context_menu(self, menu, x, y):
         from Qt.QtGui import QAction
         scaling_menu = menu.addMenu("Histogram Scaling")