Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclose info and hash ids #207

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Disclose info and hash ids #207

merged 11 commits into from
Feb 26, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added *security* Issues affecting safety/security (include undefined behaviours) feature NEw feature request labels Feb 16, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Feb 16, 2024
Comment on lines 185 to 196
e.commit_to(&self.ffv);
e.commit_to(&self.subset_of.as_ref().map(Root::schema_id));

e.commit_to(&self.global_types);
e.commit_to(&self.owned_types);
e.commit_to(&self.valency_types);
e.commit_to(&self.genesis);
e.commit_to(&self.extensions);
e.commit_to(&self.transitions);

e.commit_to(&self.type_system.id());
e.commit_to(&self.script);
Copy link
Member

@crisdut crisdut Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid the error: commit encoder can commit only to named types

Suggested change
e.commit_to(&self.ffv);
e.commit_to(&self.subset_of.as_ref().map(Root::schema_id));
e.commit_to(&self.global_types);
e.commit_to(&self.owned_types);
e.commit_to(&self.valency_types);
e.commit_to(&self.genesis);
e.commit_to(&self.extensions);
e.commit_to(&self.transitions);
e.commit_to(&self.type_system.id());
e.commit_to(&self.script);
e.commit_to(&self);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we will be back to the round 1 with creating commitments to rangeproofs and not having deterministic transaction ids.

We need here to make named types for all the collections... or change the way CommitEngine works in commit_verify crate. I will try to do this ASAP.

... so tired of these commitments ...

Copy link
Member

@crisdut crisdut Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we will be back to the round 1 with creating commitments to rangeproofs and not having deterministic transaction ids.

We need here to make named types for all the collections... or change the way CommitEngine works in commit_verify crate. I will try to do this ASAP.

Yes, I comment in another review. I believe it makes more sense to use a wrapper, to avoid this in the future.

@dr-orlovsky dr-orlovsky merged commit d4f96c9 into vesper Feb 26, 2024
@dr-orlovsky dr-orlovsky self-assigned this Feb 26, 2024
@dr-orlovsky dr-orlovsky deleted the disclose branch April 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature NEw feature request *security* Issues affecting safety/security (include undefined behaviours)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants