-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclose info and hash ids #207
Conversation
148a3f4
to
4529302
Compare
src/schema/schema.rs
Outdated
e.commit_to(&self.ffv); | ||
e.commit_to(&self.subset_of.as_ref().map(Root::schema_id)); | ||
|
||
e.commit_to(&self.global_types); | ||
e.commit_to(&self.owned_types); | ||
e.commit_to(&self.valency_types); | ||
e.commit_to(&self.genesis); | ||
e.commit_to(&self.extensions); | ||
e.commit_to(&self.transitions); | ||
|
||
e.commit_to(&self.type_system.id()); | ||
e.commit_to(&self.script); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid the error: commit encoder can commit only to named types
e.commit_to(&self.ffv); | |
e.commit_to(&self.subset_of.as_ref().map(Root::schema_id)); | |
e.commit_to(&self.global_types); | |
e.commit_to(&self.owned_types); | |
e.commit_to(&self.valency_types); | |
e.commit_to(&self.genesis); | |
e.commit_to(&self.extensions); | |
e.commit_to(&self.transitions); | |
e.commit_to(&self.type_system.id()); | |
e.commit_to(&self.script); | |
e.commit_to(&self); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we will be back to the round 1 with creating commitments to rangeproofs and not having deterministic transaction ids.
We need here to make named types for all the collections... or change the way CommitEngine works in commit_verify
crate. I will try to do this ASAP.
... so tired of these commitments ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, we will be back to the round 1 with creating commitments to rangeproofs and not having deterministic transaction ids.
We need here to make named types for all the collections... or change the way CommitEngine works in
commit_verify
crate. I will try to do this ASAP.
Yes, I comment in another review. I believe it makes more sense to use a wrapper, to avoid this in the future.
No description provided.