Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM epic revisioning and audit #280

Open
wants to merge 7 commits into
base: feat/fungible-nonconf
Choose a base branch
from
Open

VM epic revisioning and audit #280

wants to merge 7 commits into from

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added bug Something isn't working documentation Improvements or additions to documentation epic Epic task covering multiple steps of implementation refactoring Code refactoring *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) labels Oct 18, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 18, 2024
@dr-orlovsky dr-orlovsky requested a review from crisdut October 18, 2024 17:20
crisdut
crisdut approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@crisdut crisdut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

I'll do some script testing next week, but it appears to be correct.

PS: I really liked the concept of suffixes in the opcodes, it really improved the reading of the scripts.

src/vm/opcodes.rs Outdated Show resolved Hide resolved
src/vm/opcodes.rs
///
/// If operation doesn't fail, the value of `st0` remains unaffected (i.e. if it was set to
/// failed state before the operation, the operation doesn't change that).
#[display("cn.g a16{dst},a16{ty}")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a recap:

Reg32, Reg16 and Reg8 are just different bit-length for the registry index, it has nothing to do with a8/a16/a32, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisdut crisdut crisdut approved these changes

Assignees
No one assigned
Labels
bug Something isn't working *consensus* Issues affecting distributed concensus documentation Improvements or additions to documentation epic Epic task covering multiple steps of implementation refactoring Code refactoring *security* Issues affecting safety/security (include undefined behaviours)
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-orlovsky @crisdut