-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hipblaslt_supported function to reflect hipblaslt supported architectures #3544
Conversation
380a583
to
95701b6
Compare
src/targets/gpu/hipblaslt.cpp
Outdated
return ((starts_with(device_name, "gfx9") and device_name >= "gfx908" and | ||
not starts_with(device_name, "gfx10")) || | ||
starts_with(device_name, "gfx110") || | ||
starts_with(device_name, "gfx120")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From hipblaslt:
Required hardware:
gfx90a card
gfx94x card
gfx110x card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To Do: confirm if gfx90a is covered by device_name >= "gfx908"
. Remove not starts_with(device_name, "gfx10"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ROCm/hipBLASLt?tab=readme-ov-file#requirements
- lists the supported HW
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3544 +/- ##
===========================================
- Coverage 92.17% 92.16% -0.02%
===========================================
Files 512 512
Lines 21393 21401 +8
===========================================
+ Hits 19720 19724 +4
- Misses 1673 1677 +4 ☔ View full report in Codecov by Sentry. |
6b3c47c
to
6fce840
Compare
6fce840
to
af78270
Compare
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Update the architectures to accurately reflect architectures that support hipblaslt.