Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the warning on using FP8 types #3564

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove the warning on using FP8 types #3564

merged 1 commit into from
Oct 29, 2024

Conversation

CharlieL7
Copy link
Collaborator

See title

@CharlieL7 CharlieL7 added the simple small or simple changes label Oct 28, 2024
@CharlieL7 CharlieL7 self-assigned this Oct 28, 2024
@CharlieL7 CharlieL7 requested a review from causten as a code owner October 28, 2024 20:46
@TedThemistokleous TedThemistokleous added the Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR label Oct 28, 2024
@TedThemistokleous
Copy link
Collaborator

LGTM

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (71fd270) to head (59385d9).
Report is 134 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3564   +/-   ##
========================================
  Coverage    92.16%   92.16%           
========================================
  Files          512      512           
  Lines        21401    21398    -3     
========================================
- Hits         19724    19722    -2     
+ Misses        1677     1676    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
59385d
Rate old
71fd27
Diff Compare
torchvision-resnet50 64 3,258.76 3,256.05 0.08%
torchvision-resnet50_fp16 64 6,982.78 6,992.26 -0.14%
torchvision-densenet121 32 2,435.18 2,434.22 0.04%
torchvision-densenet121_fp16 32 4,084.26 4,079.64 0.11%
torchvision-inceptionv3 32 1,637.83 1,637.47 0.02%
torchvision-inceptionv3_fp16 32 2,759.72 2,759.60 0.00%
cadene-inceptionv4 16 776.15 776.43 -0.04%
cadene-resnext64x4 16 811.78 811.29 0.06%
slim-mobilenet 64 7,533.78 7,528.80 0.07%
slim-nasnetalarge 64 211.48 211.45 0.01%
slim-resnet50v2 64 3,503.84 3,505.64 -0.05%
bert-mrpc-onnx 8 1,150.72 1,147.47 0.28%
bert-mrpc-tf 1 464.13 478.08 -2.92%
pytorch-examples-wlang-gru 1 421.62 431.87 -2.37%
pytorch-examples-wlang-lstm 1 382.29 381.81 0.13%
torchvision-resnet50_1 1 784.54 803.39 -2.35%
cadene-dpn92_1 1 400.25 396.73 0.89%
cadene-resnext101_1 1 381.86 382.47 -0.16%
onnx-taau-downsample 1 342.57 343.15 -0.17%
dlrm-criteoterabyte 1 33.34 33.34 0.01%
dlrm-criteoterabyte_fp16 1 52.72 52.77 -0.10%
agentmodel 1 8,059.97 8,446.23 -4.57% 🔴
unet_fp16 2 58.83 58.90 -0.12%
resnet50v1_fp16 1 959.82 959.17 0.07%
resnet50v1_int8 1 1,030.76 1,004.97 2.57%
bert_base_cased_fp16 64 1,171.53 1,171.31 0.02%
bert_large_uncased_fp16 32 363.32 363.39 -0.02%
bert_large_fp16 1 198.87 201.09 -1.10%
distilgpt2_fp16 16 2,200.42 2,203.95 -0.16%
yolov5s 1 532.28 535.07 -0.52%
tinyllama 1 43.69 43.47 0.51%
vicuna-fastchat 1 175.92 172.75 1.83%
whisper-tiny-encoder 1 418.13 418.21 -0.02%
whisper-tiny-decoder 1 431.18 427.43 0.88%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit c70e994 into develop Oct 29, 2024
37 of 41 checks passed
@causten causten deleted the remove_fp8_warning branch October 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants