Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to trace quantization passes #3571

Merged
merged 2 commits into from
Oct 30, 2024
Merged

add flag to trace quantization passes #3571

merged 2 commits into from
Oct 30, 2024

Conversation

shivadbhavsar
Copy link
Contributor

@shivadbhavsar shivadbhavsar commented Oct 29, 2024

Currently if we do something like:
driver compile model.onnx --fp16

The quantize_fp16 pass will be run before compilation (meaning MIGRAPHX_TRACE_COMPILE will not be able to trace passes run here). Needed to use this trace for debugging so might be useful to merge in

@shivadbhavsar shivadbhavsar requested review from a team and causten as code owners October 29, 2024 19:10
@shivadbhavsar shivadbhavsar self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (6faf926) to head (8ff7567).
Report is 130 commits behind head on develop.

Files with missing lines Patch % Lines
src/quantization.cpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3571      +/-   ##
===========================================
- Coverage    92.16%   92.16%   -0.01%     
===========================================
  Files          512      512              
  Lines        21398    21403       +5     
===========================================
+ Hits         19722    19726       +4     
- Misses        1676     1677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten merged commit 45b59bc into develop Oct 30, 2024
39 of 43 checks passed
@causten causten deleted the quant_trace_flag branch October 30, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants