Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fixed instruction::replace() logic. " #3572

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Revert "Fixed instruction::replace() logic. " #3572

merged 1 commit into from
Oct 29, 2024

Conversation

causten
Copy link
Collaborator

@causten causten commented Oct 29, 2024

Reverts #3553

@causten causten requested review from tcgu-amd and CharlieL7 October 29, 2024 20:58
CharlieL7
CharlieL7 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@CharlieL7 CharlieL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to open another PR with a fixed version of #3553.

@pfultz2
Copy link
Collaborator

pfultz2 commented Oct 29, 2024

Why are we reverting this PR? What is the issue?

@CharlieL7
Copy link
Collaborator

CharlieL7 commented Oct 29, 2024 •
edited
Loading

Why are we reverting this PR? What is the issue?

Failing our tests https://github.com/ROCm/AMDMIGraphX/actions/runs/11560813155/job/32178475669. Tests probably need updates

@causten causten merged commit 6faf926 into develop Oct 29, 2024
34 of 41 checks passed
@causten causten deleted the revert-3553-fix_replace branch October 29, 2024 23:08
causten added a commit that referenced this pull request Oct 29, 2024
@causten
Revert "Revert "Fixed instruction::replace() logic. (#3553)" (#3572)"
c7e2d8d 
This reverts commit 6faf926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcgu-amd tcgu-amd tcgu-amd approved these changes

@kahmed10 kahmed10 kahmed10 approved these changes

@CharlieL7 CharlieL7 CharlieL7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@causten @pfultz2 @CharlieL7 @kahmed10 @tcgu-amd