-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netron ouptut fix #3778
Netron ouptut fix #3778
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3778 +/- ##
========================================
Coverage 92.29% 92.29%
========================================
Files 519 519
Lines 22217 22217
========================================
Hits 20505 20505
Misses 1712 1712 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
…MDMIGraphX into netron_ouptut_fix
{ | ||
// cppcheck-suppress useStlAlgorithm | ||
dim.push_back({{"dimValue", len}}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the std::back_inserter
not work with value
class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, its supposed to be an object.
shape_lens.end(), | ||
std::back_inserter(dim), | ||
[](std::size_t len) { return len; }); | ||
value dim = value({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually value::object{}
would be cleaner here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, didn't realize that's how it worked.
Fixing a bug with the output dims formatting. Some update with Netron broke the string output on attributes so disabling it.