Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocr: set underlying type of hsa_region #289

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from

Conversation

dayatsin-amd
Copy link
Collaborator

Set underlying type of hsa_region_info_t, hsa_amd_region_info_t to int.

Change-Id: Ibf97a025eec6176d8e28af8009e9bd6795ca061f

Set underlying type of hsa_region_info_t, hsa_amd_region_info_t
to int.

Change-Id: Ibf97a025eec6176d8e28af8009e9bd6795ca061f
@dayatsin-amd
Copy link
Collaborator Author

@LunNova I cannot update your PR here:
#274

Can you see whether this patch would work for you?

@LunNova
Copy link
Contributor

LunNova commented Jan 31, 2025

@tcgu-amd mentioned this approach will still cause a problem for roctracer because it's on too old a C++ version to support this syntax and depends on this API.

Locally I am able to build with this PR and it looks good.

@tcgu-amd
Copy link

@tcgu-amd mentioned this approach will still cause a problem for roctracer because it's on too old a C++ version to support this syntax and depends on this API.

Locally I am able to build with this PR and it looks good.

Minor correction: it is because roctracer compiles with a c compiler and uses the header files.

@tcgu-amd
Copy link

@tcgu-amd mentioned this approach will still cause a problem for roctracer because it's on too old a C++ version to support this syntax and depends on this API.

Locally I am able to build with this PR and it looks good.

So I think David's PR should be able to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants