Enable hipRTC compilation of codegen tests #1520
Conversation
music-dino
commented
Sep 18, 2024
•
music-dino
commented
- Enable hipRTC compilation for codegen tests
- Exclude code paths that trip up hipRTC with #ifdef HIPCC_RTC
- Implement missing type_traits constructs for the hipRTC code path
music-dino
changed the title
music-dino
requested review from
junliume,
illsilin,
carlushuang and
aosewski
as code owners
codegen/test/common.hpp
Outdated
| return {p.first, p.second}; | ||
| }); | ||
| std::transform(ck_headers.begin(), ck_headers.end(), std::back_inserter(result), [](auto& p) { | ||
| return rtc::src_file{p.first, content_wrapper(p.second)}; |
There was a problem hiding this comment.
Remove content_wrapper, just do rtc::src_file{p.first, p.second}.
There was a problem hiding this comment.
When I remove the wrapper, hiprtcCreateProgram fails with HIPRTC_ERROR_INVALID_INPUT. I have to take a closer look to see what's going on.
There was a problem hiding this comment.
For some reason, hipRTC fails if there's no whitespace before the contents. I implemented a workaround for now.
|
Hi Mirza, could you please use the ROCm/codegen-enable-hiprtc branch for any further commits? This will enable us to run the CI tests autometically. |
Unfortunately, I don't have the required permissions to push to that branch. |
- Move descriptor for gemm_softmax_gemm to different branch
|
Moved to #1574 |
