Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Fix inconsistent overrides #63

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix inconsistent overrides #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4cb9e4
Fix inconsistent overrides
aaronmondal Mar 6, 2023
9073295
Merge branch 'develop' into fix-overrides
aaronmondal Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hip_graph_internal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,11 +1093,11 @@ class hipGraphMemcpyNode : public hipGraphNode {
pCopyParams_ = new hipMemcpy3DParms(*rhs.pCopyParams_);
}

hipGraphNode* clone() const {
hipGraphNode* clone() const override {
return new hipGraphMemcpyNode(static_cast<hipGraphMemcpyNode const&>(*this));
}

hipError_t CreateCommand(hip::Stream* stream) {
hipError_t CreateCommand(hip::Stream* stream) override {
if (IsHtoHMemcpy(pCopyParams_->dstPtr.ptr, pCopyParams_->srcPtr.ptr, pCopyParams_->kind)) {
return hipSuccess;
}
Expand Down Expand Up @@ -1133,14 +1133,14 @@ class hipGraphMemcpyNode : public hipGraphNode {
std::memcpy(pCopyParams_, params, sizeof(hipMemcpy3DParms));
return hipSuccess;
}
hipError_t SetParams(hipGraphNode* node) {
hipError_t SetParams(hipGraphNode* node) override {
const hipGraphMemcpyNode* memcpyNode = static_cast<hipGraphMemcpyNode const*>(node);
return SetParams(memcpyNode->pCopyParams_);
}
// ToDo: use this when commands are cloned and command params are to be updated
hipError_t ValidateParams(const hipMemcpy3DParms* pNodeParams);

std::string GetLabel(hipGraphDebugDotFlags flag) {
std::string GetLabel(hipGraphDebugDotFlags flag) override {
size_t offset = 0;
const HIP_MEMCPY3D pCopy = hip::getDrvMemcpy3DDesc(*pCopyParams_);
hipMemoryType srcMemoryType = pCopy.srcMemoryType;
Expand Down Expand Up @@ -1215,7 +1215,7 @@ class hipGraphMemcpyNode : public hipGraphNode {
}
return label;
}
std::string GetShape(hipGraphDebugDotFlags flag) {
std::string GetShape(hipGraphDebugDotFlags flag) override {
if (flag == hipGraphDebugDotFlagsMemcpyNodeParams || flag == hipGraphDebugDotFlagsVerbose) {
return "record";
} else {
Expand Down