Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle version catalogue #5237

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Feb 13, 2025

Identify the Bug or Feature request

Closes #5214

Description of the Change

Add a libs.versions.toml for tracking desired versions of packages. These are referenced in the build.gradle files via the libs.* variables in the plugins { .. } and dependencies { ... } blocks.

Largely the dependencies have been kept identical to the current state of develop. Exceptions are:

  • imageio-* packages are all on 3.12.0 instead of a mix of 3.10.1 and 3.12.0
  • handlerbars* packages are both on 4.4.0 instead of a mix of 4.3.1 and 4.4.0
  • graalvm* packages are both on 21.2.0 instead of a mix of 21.1.0 and 21.2.0
  • junit- packages are all on 5.11.4 instead of a mix of 5.10.2 and 5.11.4
  • junit-platform-launcher has a version specified now

Possible Drawbacks

It's unclear how well dependabot will handle this.

Documentation Notes

N/A

Release Notes

  • Changed the build scripts to use a central version catalogue for all dependencies.

This change is Reviewable

Also clean things up by reordering dependencies so related libraries are near to each other and so there are no
duplicates.
@kwvanderlinde kwvanderlinde self-assigned this Feb 13, 2025
@github-actions github-actions bot added build-configuration code-maintenance Adding/editing javadocs, unit tests, formatting. labels Feb 13, 2025
@kwvanderlinde kwvanderlinde changed the title Refactor/5214 version catalogue Add gradle version catalogue Feb 13, 2025
@cwisniew
Copy link
Member

I will merge it, lets see how dependabot goes, if it chokes I will remove it

@cwisniew cwisniew added this pull request to the merge queue Feb 13, 2025
@kwvanderlinde
Copy link
Collaborator Author

I will merge it, lets see how dependabot goes, if it chokes I will remove it

Exactly my thought. 👍

Merged via the queue into RPTools:develop with commit 7594133 Feb 13, 2025
5 checks passed
@kwvanderlinde kwvanderlinde deleted the refactor/5214-version-catalogue branch February 13, 2025 22:00
@kwvanderlinde
Copy link
Collaborator Author

Dependabot has successfully opened up another round of updates. Will obviously keep an eye on it, but for now at least that seems to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-configuration code-maintenance Adding/editing javadocs, unit tests, formatting.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Refactoring]: Add version catalogue for gradle dependencies
2 participants