Fix do_serial_cons function for Raspberry Pi 5
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a bug in the `do_serial_cons` function in `raspi-config` at Raspberry Pi 5. On previous Raspberry Pi devices under Raspberry Pi 4, `console=serial0` in cmdline.txt allows the login shell via UART works correctly. However, on Raspberry Pi 5 devices, `console=ttyAMA0` makes login shell via UART to work. I considered just posting the issue, but I want to contribute to the open-source project, so I decided to submit a pull request. - Tested on Raspberry Pi 5 & 4 (latest as of 2024-12-21) [neofetch output of Pi 5] - OS: `Debian GNU/Linux 12 (bookworm) aarch64` - Host: `Raspberry Pi 5 Model B Rev 1.0` - Kernel: `6.6.51+rpt-rpi-2712` - `raspi-config` Version: `20211221` [neofetch output of Pi 4] - OS: Debian GNU/Linux 12 (bookworm) aarch64 - Host: Raspberry Pi 4 Model B Rev 1.4 - Kernel: 6.6.51+rpt-rpi-v8 - `raspi-config` Version: `20211221` Signed-off-by: thsvkd <[email protected]>
thsvkd
changed the title
do_serial_cons function for Raspberry Pi 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the
do_serial_consfunction inraspi-configat Raspberry Pi 5. On previous Raspberry Pi devices under Raspberry Pi 4,console=serial0in cmdline.txt allows the login shell via UART works correctly. However, on Raspberry Pi 5 devices,console=ttyAMA0makes login shell via UART to work.I considered just posting the issue, but I want to contribute to the open-source project, so I decided to submit a pull request.
Tested on Raspberry Pi 5 & 4 (latest as of 2024-12-21)
[neofetch output of Pi 5]
Debian GNU/Linux 12 (bookworm) aarch64Raspberry Pi 5 Model B Rev 1.06.6.51+rpt-rpi-2712raspi-configVersion:20211221[neofetch output of Pi 4]
Debian GNU/Linux 12 (bookworm) aarch64Raspberry Pi 4 Model B Rev 1.46.6.51+rpt-rpi-v8raspi-configVersion:20211221