Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools]: fix the issue of missing commands in compile_commands.json #9856

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

aka-adi
Copy link
Contributor

@aka-adi aka-adi commented Jan 2, 2025

拉取/合并请求描述:(PR description)

[
#9782
修复了--cdb生成的compile_commands.json文件中commands缺失的问题
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the tools label Jan 2, 2025
@supperthomas
Copy link
Member

感谢提交PR,
可否帮忙试下该功能是否正常使用?顺便帮忙修复一下
https://club.rt-thread.org/ask/article/21c188cfc2c3df58.html
可能要稍微改下路径,
在tools下面搜索关键字compile_commands.json 即可。

Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile_commands.json

Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile_commands.json

tools/building.py Show resolved Hide resolved
@supperthomas supperthomas merged commit 9291946 into RT-Thread:master Jan 2, 2025
46 checks passed
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 24, 2025
…T-Thread#9856)

* [tools]: fix the issue of missing commands in compile_commands.json

* [tools]: fix the path of compile_commands.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants