Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in setting PLIC_PRIORITY[n] #9862

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

KennethLiu61
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

发现c906_little目录下的interrupt.c中,设置PLIC_PRIORITY[n] 这个寄存器存在BUG。

你的解决方案是什么 (what is your solution)

按照C906的官方文档《玄铁 C906 R2S1 用户手册》,正确配置PLIC_PRIORITY[n]。
每一个寄存器代表一个硬件中断的优先级。
代码中for循环遍历,但是使用 IRQ_MAX_NR / 4 ,导致配置的寄存器减少了4倍。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/cvitek/c906_little
  • .config: NA
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [V] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [V] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [V] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [V] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [V] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [V] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [V] 代码是高质量的 Code in this PR is of high quality
  • [V] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [V] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP BSP: Cvitek BSP related with cvitek labels Jan 3, 2025
@supperthomas supperthomas requested a review from unicornx January 3, 2025 14:56
@unicornx unicornx added the Arch: RISC-V BSP related with risc-v label Jan 4, 2025
@BernardXiong
Copy link
Member

请签署下CLA,谢谢

image

Copy link
Contributor

@unicornx unicornx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改动没有问题,唯一希望改进的是 commit 的内容,可以将在 PR 中的描述(最好用英文,机器翻译一下即可写在 commit 的内容中。

其实只要在 commit 中写好了修改的原因等,在提交 PR 时自动就会出现在 PR 的描述中。

具体 commit 内容的编写方法可以参考:https://github.com/plctlab/plct-rt-thread/blob/notes/0.notes/20241212-github-tips.md#1-%E5%A6%82%E4%BD%95%E7%BC%96%E5%86%99-git-commit-message

description: In the bsp/cvitek/c906_little/board/interrupt.c, There is an issue with
setting the PLIC_PRIORITY[n].

analysis: PLIC_PRIORITY[n] each register corresponds to the priority of
a hardware interrupt number.

Solution: Each register is 4 bytes.
Multiply the total number of IRQs by 4 instead of dividing by 4.

Signed-off-by: Liu Gui <[email protected]>
@KennethLiu61
Copy link
Contributor Author

已经按要求更新了commit内容了,帮忙再review下哦。

@Rbb666 Rbb666 merged commit 95064ed into RT-Thread:master Jan 16, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: RISC-V BSP related with risc-v BSP: Cvitek BSP related with cvitek BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants