Upstream #3
Merged
Upstream #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate installer jsons * Bump to version2 * Include file size * Add min java version * Exclude signature info from shaded jars * Add a little script to aid installing a test version to the minecraft launcher.
…icMC#850) * Allow replacing the default mod directory via fabric.modDir * Apply requested changes * Fix checkstyle failures
* Migrate to mapping io * Keep enum class members * Fix and improve TinyRemapperMappingsHelper * Fix MixinRemapper * Fix missing src namespace * Cleanup and test MappingResolver * Lazily load mapping data if required. * Update mapping-io * Update mapping-io * Don't read method args/var names, or comments. * Only load mappings when needed.
FabricMC#857) * Prioritize mods with higher provided versions if their main id differs * Need to keep provided+actual id groups together so they can always be sorted * Switch to insertion sort based approach
* Fix mappings when mappings file is in a folder * pressed the space bar to make checkstyle happy
* Add Chinese Traditional * Add Traditional Chinese
* fix inputGameJars ObjectShare mutating after being set * make defensive copy unmodifiable * document behavior
This reverts commit 8ae3c8e.
IPECTER
pushed a commit
that referenced
this pull request
Aug 4, 2024
* Added logging for non-fabric mods with tests. Co-authored-by: Douglas Fischer <[email protected]> Co-authored-by: Robin Claesson <[email protected]> Co-authored-by: Acuadragon100 <[email protected]> Co-authored-by: Erik Vinblad <[email protected]> * Synchronise the non-fabric mod list to prevent threading issues. * Only print warning if at least 1 non-fabric mod is found. * Fix: @VisibleForTesting and static import of Mockito::when (#3) * feat(FabricMC#644): add @VisibleForTesting for the feat impl method * Use static import for Mockito::when. * Use @VisibleForTesting instead of reflection. Co-authored-by: Douglas Fischer <[email protected]> Co-authored-by: wenqic <[email protected]> Co-authored-by: Acuadragon100 <[email protected]> * Style improvements. (FabricMC#4) Co-authored-by: Douglas Fischer <[email protected]> * Use JetBrains' VisibleForTesting annotation instead of Google's. --------- Co-authored-by: Douglas Fischer <[email protected]> Co-authored-by: Robin Claesson <[email protected]> Co-authored-by: Erik Vinblad <[email protected]> Co-authored-by: Douglas Fischer <[email protected]> Co-authored-by: wenqic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.