add support for riscv32imac-esp-espidf and riscv32imc-esp-espidf #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming back to running a121-rs on an esp32c3/esp32c6 - and seems some things changed in the meantime, especially with this new a121-sys crate. I extended the bindings generation to set the correct cross-compilation target (
riscv32-esp-elf), and to also automatically find the sysroot and include directories for theriscv32imac-esp-espidfandriscv32imc-esp-espidftargets, which are the c3 and c6 in combination with the std environment (via https://github.com/esp-rs/esp-idf-svc).Will mark this as ready to merge once I have confirmed that this runs successfully on the c3/c6.
Still having a couple issues until we get there:
riscv32-esp-elf-gccis no longer installed by espup, and instead is only present in the .embuild folder of the main application crate (i.e..embuild/espressif/tools/riscv32-esp-elf/esp-13.2.0_20240530/riscv32-esp-elf/bin) or in an installation done by the VSCode extension (i.e.~/.espressif/tools/riscv32-esp-elf/...-> I added a note to the readme about sourcing the esp installation first to make sureriscv32-esp-elf-gccis in PATH.SpiDeviceDriver (from esp-idf-hal) doesn´t seem to be compatible with what the Radar's new method seems to expect→ I have refactored a121-rs to not need an SPI adapter at all and work with the normal embedded_hal traits, a separate PR will follow