More stats

[mzuenni]

more stats (mostly useful as fun stats for solution slides)

[RagnarGrootKoerkamp]

Can you improve the installation instructions for pygount? I don't have it and there's no pacman/AUR package.. Did you install it in your user environment with pip or so?

[mzuenni]

yes installed it with pip... we could also use non python code to do the counting...

[mpsijm]

Or do the counting manually in Python? Iterating over files in directories and discarding comments in 5 languages shouldn't be too much code 🙂

[mzuenni]

I would say counting this ourselves is not an option... and just for the fun, how many c++ lines of code are this:

//this is a comment\
is this a comment?
int main() {}

cloc says 2 where as pygount says 1...

[mzuenni]

any idea for more stats that we want to calculate?

[mzuenni]

@RagnarGrootKoerkamp the code now only requires pygments and not pygount, is that easier to install?

[mpsijm]

Fixed the rebase, it looked like all commits from master ended up in this branch without the base actually changing, so the commits were duplicated 😛 But not anymore 😄

I can confirm that it works on my machine, I already had python-pygments installed via Pacman. I like the approach of reusing the Pygments lexer data for counting the number of lines of code 😄

I'm not sure if --slides is the best name for the flag, because it doesn't actually do anything with slides (the fact that we may use these stats for the slides, is something else). If we want to name the flag for the thing that it does (namely analyzing the submissions, test data, and Git repo), some suggestions could be --more-analysis, --more-stats, --more, --analyse-data, or --analyse-repo (not sure about - vs. _). Maybe we could (ab)use --verbose to trigger these extra stats, but that also feels slightly odd.

[mzuenni]

Fixed the rebase, it looked like all commits from master ended up in this branch without the base actually changing, so the commits were duplicated 😛 But not anymore 😄

whoops and thanks ^^

I'm not sure if --slides is the best name for the flag

hm simply --more or --all instead?

[mpsijm]

Hmm, --all also has a different meaning for other commands already 🤔 But I'm fine with --more 🙂

[RagnarGrootKoerkamp]

Tested the latest version and LGTM, so feel free to merge. Haven't checked the latest code in detail.

[mpsijm]

Why not datetime.strptime (https://stackoverflow.com/a/2265383) to avoid an additional dependency?

Also, this/these additional (optional) dependenc(y/ies) should be mentioned in other places, I think.

[mpsijm]

Didn't check the code inside more_stats, but that should be fine since it's behind the --more flag and it works 😛 For the code around it, I only have this above comment about dependencies 🙂