-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[latex] Add command problem_slides #413
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9a9ab92
[latex] Add command problem_slides
mpsijm 7577d30
[latex] Support `bt problem_slides` at the problem level
mpsijm 3480f1e
[latex][skel][test] Problem Slides: add templates and tests
mpsijm a0ef9c3
[doc] Update documentation for LaTeX commands (a.o. add problem_slides)
mpsijm 4a325a3
[latex] Problem Slides at contest level: warn for each problem missin…
mpsijm 33ec56e
[zip] Only build the problem slides if at least one problem has the T…
mpsijm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this (the
no_solutions
flag) be more granular? It's annoying if things fail because no problem slides are present.Or maybe better is to never make it an error if problem slides are missing? (But that's kinda tricky when you want slides for all problems?)
Also I checked an doing
bt problem_slides
at the contest level with someproblem-slide.en.tex
missing crashes in latex (because file not found). We should probably detect when there's not a single problem-slide present and then just Log that (without error). When only some files are present, it's fine to error IMO.At the problem level it gives a nice message
problem-slide.en.tex not found
, so there all is good.Otherwise LGTM! Thanks for making the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! Will reduce some errors to warnings today or tomorrow 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some extra checks 🙂 The behaviour at the problem level hasn't changed, this is the new behaviour at the contest level:
problem-slide.*.tex
are present:bt problem_slides
will warn for all problems, followed by a failing LaTeX compilation (because the user is explicitly trying to compile them)bt zip
will log "No problem has problem-slide.*.tex, skipping problem slides"problem-slide.*.tex
is present:bt problem_slides
andbt zip
will warn for the problems that do not have it, but will compile the restThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. Thanks! Merging now.