Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gradient Tooltip #1313

Closed
wants to merge 17 commits into from
Closed

Added Gradient Tooltip #1313

wants to merge 17 commits into from

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Aug 1, 2024

Fixes Issue🛠️

Closes #1248

Description👨‍💻

Added a new tooltip in the library - The gradient Tooltip

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screen Shot 2024-08-01 at 10 16 16 PM
Screen Shot 2024-08-01 at 10 16 27 PM

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 6fe28c0
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/66b60d29692d4d000805ea38
😎 Deploy Preview https://deploy-preview-1313--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hars-21, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 1, 2024

@Rakesh9100 Please review my PR

@Rakesh9100
Copy link
Owner

Pls don't make any unnecessary indentation changes in tooltips.html file, just add your component part and no other changes @hars-21

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Aug 2, 2024
@Rakesh9100 Rakesh9100 mentioned this pull request Aug 2, 2024
4 tasks
@hars-21 hars-21 reopened this Aug 3, 2024
@hars-21
Copy link
Contributor Author

hars-21 commented Aug 3, 2024

Hey @Rakesh9100 I have made the changes you asked. Added mario tooltip and fixed the indentation. Please review.

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 4, 2024

@Rakesh9100 please review the new changes. Thanks!

@Rakesh9100
Copy link
Owner

Keep all your file indentation as 4 spaces and not 8 tabs and make the new commits @hars-21

And always do the same for your every PR!

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 4, 2024

Ok , will make the changes

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 4, 2024

@Rakesh9100 Done!

Copy link
Contributor Author

@hars-21 hars-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes, IDK why in github it is showing like this but i have removed the previous indentation.

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 5, 2024

@Rakesh9100 Please merge this PR. If you find indentation error after merging, you can revert it back. I have fixed.

@hars-21 hars-21 closed this Aug 9, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Aug 21, 2024
@Rakesh9100 Rakesh9100 changed the title Gradient Tooltip Added Added Gradient Tooltip Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Gradient Tooltip and Mario Themed Tooltip
2 participants